• Ephera
    285•7 months ago

    Tangentially related rant: We had a new contributor open up a pull request today and I gave their changes an initial look to make sure no malicious code is included.
    I couldn’t see anything wrong with it. The PR was certainly a bit short, but the task they tackled was pretty much a matter of either it works or it doesn’t. And I figured, if they open a PR, they’ll have a working solution.

    …well, I tell the CI/CD runner to get going and it immediately runs into a compile error. Not an exotic compile error, the person who submitted the PR had never even tried to compile it.

    Then it dawned on me. They had included a link to a GitHub Copilot workspace, supposedly just for context.
    In reality, they had asked the dumbass LLM to do the change described in the ticket and figured, it would produce a working PR right off the bat. No need to even check it, just let the maintainer do the validation.

    In an attempt to give them constructive feedback, I tried to figure out, if this GitHub Copilot workspace thingamabob had a Compile-button that they just forgot to click, so I actually watched Microsoft’s ad video for it.
    And sure enough, I saw right then and there, who really was at fault for this abomination of a PR.

    The ad showed exactly that. Just chat a bit with the LLM and then directly create a PR. Which, yes, there is a theoretical chance of this possibly making sense, like when rewording the documentation. But for any actual code changes? Fuck no.

    So, most sincerely: Fuck you, Microsoft.

      • @smiletolerantly
        4•7 months ago

        Lmao, what, that’s wild. How did they justify this??

          • @smiletolerantly
            5•7 months ago

            Oof.

            My employer pays a buttload bottomload of money to CircleCI - for extensive checks (build, lint, formatting, full test suite, as well as custom scripts for translation converage, docs,… for the full tech stack) on every push. Reviews start only when everything passes.

            I think you have given me a new-found appreciation for the reasoning behind that decision… 😄

    • @[email protected]English
      16•7 months ago

      Commit with Co-authored-by: Copilot

      or maybe better --author=Copilot

      It would certainly help evaluate submissions to have that context

  • oce 🐆
    133•7 months ago

    I had a Pycharm linter with “inconsiderate writing list” flag my use of “bi” as inappropriate, recommending to use “bisexual” instead. In my data job, BI, means business intelligence, it’s everywhere.

    • @[email protected]English
      7•7 months ago

      The problem was named after an incident in 1996 in which AOL’s profanity filter prevented residents of the town of Scunthorpe, North Lincolnshire, England, from creating accounts with AOL, because the town’s name contains the substring “cunt”.

      haha

    • @[email protected]
      25•7 months ago

      Google: kill child process
      FBI: ಠ_ಠ

      Google: kill child process linux console
      FBI:（︶︿︶)

  • @[email protected]
    43•7 months ago

    I’ve been tempted to create a bot that does nothing but search comments in code for misspelled words and create pull requests for them.

    If it stays in comments, little chance in breaking a working codebase and I’d have an insane amount of commits and contributions to a wide variety of codebases for my resume.

    I’ll never be a top tier coder. But I might make management.

    • @[email protected]
      29•7 months ago

      In case that wasn’t satire, please don’t 🥲 A small typo in a comment is not a big issue, and even if the PR is straightforward, a maintainer still has to take some time reviewing it, which takes time away from fixing actual bugs 😢

    • @[email protected]
      3•7 months ago

      A better use of your time is to improve documentation. Developers generally hate documentation so it’s often in need of improvement. Rewrite confusing sentences. Add tutorials that are missing. Things like that. You don’t necessarily have to be a good developer or even understand the code of the project; you just have to have some knowledge of the project as an end user.

  • NumG
    36•7 months ago

    I am in doubt. That wouldn’t even compile. But who am I to think somebody changing something like this would actually do a test compilation afterwards…

    • @[email protected]
      43•7 months ago

      HTML isn’t compiled, and unknown attributes are allowed. The best practice is to prefix non-standard attributes with data- (e.g. <div data-foo="test">) but nothing enforces that. Custom attributes can be retrieved in JavaScript or targeted in CSS rules.

    • @[email protected]
      11•7 months ago

      Or just have some random subset of browsers support them for some reason and other browsers not so much. It’s the html way.

  • pflanzenregal
    27•7 months ago

    OMG this took me way too long to get. They replace the substring “ass” 😭😭

    • @[email protected]English
      10•7 months ago

      those are terms, this is substrings within words

      I haven’t seen branches or variables being called arse

      Then again, I do like to catch exceptions as up so I can throw up

    • @[email protected]
      2•7 months ago

      At least for that we have replacement names that make sense (like primary and secondary or replica).

OSZAR »